Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Temporarily disable error handling for Get-AzKeyVault -InRemovedState #5316

Merged
1 commit merged into from
Feb 2, 2023
Merged

Temporarily disable error handling for Get-AzKeyVault -InRemovedState #5316

1 commit merged into from
Feb 2, 2023

Conversation

benbp
Copy link
Member

@benbp benbp commented Feb 2, 2023 •
edited
Loading

Follow-up tracked in #5316

@benbp benbp requested a review from weshaggard as a code owner February 2, 2023 00:58
@benbp benbp added the Central-EngSys This issue is owned by the Engineering System team. label Feb 2, 2023
@benbp benbp self-assigned this Feb 2, 2023
@benbp benbp requested a review from mikeharder February 2, 2023 00:58
@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

weshaggard
weshaggard reviewed Feb 2, 2023
View reviewed changes
eng/common/scripts/Helpers/Resource-Helpers.ps1
# | '2016-10-01,2018-02-14-preview,2018-02-14,2019-09-01,2021-04-01-preview,2021-06-01-preview,2021-10-01,2021-11-01-preview'.
try {
# Get deleted Key Vaults for the current subscription.
$deletedKeyVaults = @(Get-AzKeyVault -InRemovedState `
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any way we can query to see if the api version exists or not?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can but at that point we may as well pin the Az module version to an older version (which we should discuss tomorrow as an approach regardless), because knowing which api version will be queried under the hood requires knowing the Az.KeyVault module version we're using.

@benbp benbp force-pushed the benbp/keyvault-cleanup-dogfood branch from 614016e to 9d34917 Compare February 2, 2023 01:10
@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

This was referenced Feb 2, 2023
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@ghost
Copy link

ghost commented Feb 2, 2023

Hello @azure-sdk!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit eaec89e into Azure:main Feb 2, 2023
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weshaggard weshaggard weshaggard left review comments

@mikeharder mikeharder mikeharder approved these changes

Assignees

@benbp benbp

Labels
Central-EngSys This issue is owned by the Engineering System team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@benbp @azure-sdk @weshaggard @mikeharder